tech/tanabata
1
1
Fork 0
Code Pull Requests Actions Releases Activity

fix(scripts): correct autotag rule direction in legacy migration

Browse Source 
The old autotags worked child -> parent (adding child_id pulled in parent_id,
per tfm__add_file_to_tag_recursive). The new tag_rules model is "when_tag
applied -> then_tag follows", so child must map to when_tag and parent to
then_tag. The transform had it reversed, so migrated rules never fired —
adding a tag added only itself.

Map child_id -> when_tag_id, parent_id -> then_tag_id. Verified on a scratch DB.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
Masahiko AMANO
2026-06-11 13:45:52 +03:00
parent f73f954b1a
commit aae0c587e8
2 changed files with 8 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
scripts/migrate-legacy/transform.sql
+7 -4
View File
@@ -92,14 +92,17 @@ JOIN user_id_map um ON um.old_id = t.creator_id
ON CONFLICT (id) DO NOTHING;
-- ---------------------------------------------------------------------------
-- 5. Tag rules (old `autotags`): parent -> when_tag, child -> then_tag.
-- 5. Tag rules (old `autotags`). In the old schema adding the child tag pulled
-- in its parent (tfm__add_file_to_tag_recursive: for child_id = t_id it adds
-- parent_id). The new model is "when_tag applied -> then_tag follows", so the
-- trigger child becomes when_tag and the auto-applied parent becomes then_tag.
-- Skip rules whose tags didn't migrate.
-- ---------------------------------------------------------------------------
INSERT INTO data.tag_rules (when_tag_id, then_tag_id, is_active)
SELECT a.parent_id, a.child_id, a.is_active
SELECT a.child_id, a.parent_id, a.is_active
FROM legacy.autotags a
WHERE EXISTS (SELECT 1 FROM data.tags t WHERE t.id = a.parent_id)
AND EXISTS (SELECT 1 FROM data.tags t WHERE t.id = a.child_id)
WHERE EXISTS (SELECT 1 FROM data.tags t WHERE t.id = a.child_id)
AND EXISTS (SELECT 1 FROM data.tags t WHERE t.id = a.parent_id)
ON CONFLICT (when_tag_id, then_tag_id) DO NOTHING;
-- ---------------------------------------------------------------------------